> On 24 Jun 2022, at 17:04, Anthony PERARD <anthony.per...@citrix.com> wrote: > > Use $(TARGETS) to collect targets. > Collect library to link against in $(LDLIBS). > Remove extra "-f" flags that is already part of $(RM). > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > --- > > Notes: > v3: > - apply changes to the new "init-dom0less" helper. > - make use of the new macro $(xenlibs-ldlibs,) > > tools/helpers/Makefile | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile > index 8d78ab1e90..7c9d671b32 100644 > --- a/tools/helpers/Makefile > +++ b/tools/helpers/Makefile > @@ -5,13 +5,13 @@ > XEN_ROOT = $(CURDIR)/../.. > include $(XEN_ROOT)/tools/Rules.mk > > -PROGS += xen-init-dom0 > +TARGETS += xen-init-dom0
Can this be TARGETS := The rest looks good, so with this addressed Reviewed-by: Luca Fancellu <luca.fance...@arm.com> I’ve also built and run the tool stack with (up to) this patch on both fvp-base for arm and qemu for x86_64 and the binaries are ok. Tested-by: Luca Fancellu <luca.fance...@arm.com>
