> From: Roger Pau Monne <roger....@citrix.com>
> Sent: Friday, July 1, 2022 9:17 PM
> 
> @@ -225,6 +225,9 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc)
> 
>  /*
>   * Interruption-information format
> + *
> + * Note INTR_INFO_NMI_UNBLOCKED_BY_IRET is also used with Exit
> Qualification
> + * field under some circumstances.
>   */
>  #define INTR_INFO_VECTOR_MASK           0xff            /* 7:0 */
>  #define INTR_INFO_INTR_TYPE_MASK        0x700           /* 10:8 */

Overall this is good. But I wonder whether the readability is slightly better
by defining a dedicate flag bit for exit qualification with a clear comment
on which events it makes sense to...

Reply via email to