On 18/07/2022 11:48, Jan Beulich wrote: > On 18.07.2022 09:18, Andrew Cooper wrote: >> With the waitqueue logic updated to not use an absolute stack pointer >> reference, the vCPU can safely be resumed anywhere. >> >> Remove VCPU_AFFINITY_WAIT completely, getting rid of two domain crashes, > I understand you mean two domain_crash() invocations here, but ... > >> and a >> logical corner case where resetting the vcpu with an oustanding waitqueue >> would crash the domain. > ... some other domain crash here?
One of the two above. It's more that resetting (would have) broken the affinity and would have triggered the domain crash. > >> Signed-off-by: Andrew Cooper <[email protected]> > I assume you've checked thoroughly that calling code hasn't > grown dependencies on execution coming back on the same CPU? Urgh yes, my trivial test case didn't encounter it, but anything with an smp_processor_id() stashed on the stack is going to end up unhappy. I'm going to have to retract half this series. (I'll follow up on the 0/$N with the longer term plan to remove this mess). ~Andrew
