On 05.07.2022 23:02, Xenia Ragiadakou wrote: > The function idle_loop() is referenced only in domain.c. > Change its linkage from external to internal by adding the storage-class > specifier static to its definitions. > > Since idle_loop() is referenced only in inline assembly, add the 'used' > attribute to suppress unused-function compiler warning.
While I see that Julien has already acked the patch, I'd like to point out that using __used here is somewhat bogus. Imo the better approach is to properly make visible to the compiler that the symbol is used by the asm(), by adding a fake(?) input. Jan
