On 06.07.2022 04:18, Sarah Newman wrote:
> A STT_SECTION symbol is not needed if if it is not used as a relocation
> target. Therefore, a section, in this case a debug section, may not have
> a secsym associated with it.
> 
> This is a livepatch backport of kpatch upstream commit [1]:
> create-diff-object: Check that the section has a secsym ba3defa
> 
> Signed-off-by: Sarah Newman <sarah.new...@computer.org>

Reviewed-by: Jan Beulich <jbeul...@suse.com>

However I think the 7-digit hash above wants either extending to at
least 10 digits (better 12), or dropping altogether for having the
full hash ...

> [1] 
> https://github.com/dynup/kpatch/commit/ba3defa06073dcc69917dbbbb9df570ca4e56612

... here anyway. But I guess the rules set forth in
xen.git:docs/process/sending-patches.pandoc could be applied here,
and hence an Origin: tag would best be used.

The other thing is: You didn't Cc any of the maintainer(s).

Jan

Reply via email to