On 01.07.22 04:19, Henry Wang wrote:
Hi Julien,-----Original Message----- Subject: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end From: Julien Grall <jgr...@amazon.com> Some tools (e.g. xenstored) always expect EINVAL to be first in xsd_errors. To be conservative, mandate that new errors should be added at the end of the array. Signed-off-by: Julien Grall <jgr...@amazon.com>While the change is looking good, just FYI there is an "ERROR" section in /xen/docs/misc/xenstore.txt that points to the io/xs_wire.h. You may want to add something there (that depends on your own taste :)) )
This documentation is meant for users of Xenstore, not for how to modify it. I think the comment is all what should be added. Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
