Hi Julien, On 24.06.2022 11:11, Julien Grall wrote: > From: Julien Grall <jgr...@amazon.com> > > A lot of places in the ARM32 assembly requires to load the physical address > of a symbol. Rather than open-coding the translation, introduce a new macro > that will load the phyiscal address of a symbol. > > Lastly, use the new macro to replace all the current open-coded version. > > Note that most of the comments associated to the code changed have been > removed because the code is now self-explanatory. > > Signed-off-by: Julien Grall <jgr...@amazon.com> > --- > xen/arch/arm/arm32/head.S | 23 +++++++++++------------ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S > index c837d3054cf9..77f0a619ca51 100644 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -65,6 +65,11 @@ > .endif > .endm > > +.macro load_paddr rb, sym > + ldr \rb, =\sym > + add \rb, \rb, r10 > +.endm > + All the macros in this file have a comment so it'd be useful to follow this convention. Apart from that: Reviewed-by: Michal Orzel <michal.or...@arm.com>
Cheers, Michal
