On 2022/06/09 19:28, Gerd Hoffmann wrote:
--- a/include/ui/console.h +++ b/include/ui/console.h @@ -139,6 +139,7 @@ typedef struct QemuUIInfo { int yoff; uint32_t width; uint32_t height; + uint32_t refresh_rate; } QemuUIInfo;/* cursor data format is 32bit RGBA */@@ -426,7 +427,6 @@ typedef struct GraphicHwOps { void (*gfx_update)(void *opaque); bool gfx_update_async; /* if true, calls graphic_hw_update_done() */ void (*text_update)(void *opaque, console_ch_t *text); - void (*update_interval)(void *opaque, uint64_t interval); void (*ui_info)(void *opaque, uint32_t head, QemuUIInfo *info); void (*gl_block)(void *opaque, bool block); } GraphicHwOps;So you are dropping update_interval, which isn't mentioned in the commit message at all. Also this patch is rather big. I'd suggest: (1) add refresh_rate (2) update users one by one (3) finally drop update_interval when no user is left. thanks, Gerd
I think 1 and 3 should have to be done once since refresh_rate and update_interval would interfere with each other otherwise. Does that make sense?
Regards, Akihiko Odaki
