On 23.05.2022 08:25, Wei Chen wrote: > x86 is using compiler feature testing to decide EFI build > enable or not. When EFI build is disabled, x86 will use an > efi/stub.c file to replace efi/runtime.c for build objects. > Following this idea, we introduce a stub file for Arm, but > use CONFIG_ARM_EFI to decide EFI build enable or not. > > And the most functions in x86 EFI stub.c can be reused for > other architectures, like Arm. So we move them to common > and keep the x86 specific function in x86/efi/stub.c. > > To avoid the symbol link conflict error when linking common > stub files to x86/efi. We add a regular file check in efi > stub files' link script. Depends on this check we can bypass > the link behaviors for existed stub files in x86/efi. > > As there is no Arm specific EFI stub function for Arm in > current stage, Arm still can use the existed symbol link > method for EFI stub files. > > Change-Id: Idf19db1ada609d05fc0c0c3b0e1e8687c9d6ac71 > Issue-Id: SCM-2240
I don't think these two lines belong in an upstream submission (I checked patch 2 and at least there they are two similar lines). > Signed-off-by: Wei Chen <wei.c...@arm.com> > Tested-by: Jiamei Xie <jiamei....@arm.com> While I'm not really happy with the Arm side, it's only the other parts which this is applicable to anyway (with the stray tags dropped): Acked-by: Jan Beulich <jbeul...@suse.com> Jan
