On 19.05.2022 14:44, Roger Pau Monné wrote:
> On Thu, May 19, 2022 at 08:50:55AM +0200, Jan Beulich wrote:
>> On 17.05.2022 15:21, Roger Pau Monne wrote:
>>> --- a/xen/arch/x86/hvm/vmx/vmx.c
>>> +++ b/xen/arch/x86/hvm/vmx/vmx.c
>>> @@ -4567,6 +4567,30 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
>>> */
>>> break;
>>>
>>> + case EXIT_REASON_NOTIFY:
>>> + __vmread(EXIT_QUALIFICATION, &exit_qualification);
>>> +
>>> + if ( exit_qualification & NOTIFY_VM_CONTEXT_INVALID )
>>> + {
>>> + perfc_incr(vmnotify_crash);
>>
>> Is this a useful event to count? We don't count other crash causes,
>> iirc.
>
> I thought it was helpful information from an admin PoV, but maybe I'm
> mistaken. I know we don't count other crash reasons, but that doesn't
> mean it won't be helpful to do so. Given that users have to opt-in to
> enable counters I suggest to leave the counter there.
Just to be explicit: I don't mind the counter, I merely find its addition
inconsistent with what we've got.
Jan
