On 09/05/2022 14:18, Roger Pau Monné wrote: > On Mon, May 09, 2022 at 01:24:07PM +0100, Andrew Cooper wrote: >> Spotted by Eclair MISRA scanner. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > Reviewed-by: Roger Pau Monné <roger....@citrix.com> > >> --- >> CC: Jan Beulich <jbeul...@suse.com> >> CC: Roger Pau Monné <roger....@citrix.com> >> CC: Wei Liu <w...@xen.org> >> CC: Stefano Stabellini <sstabell...@kernel.org> >> CC: Julien Grall <jul...@xen.org> >> CC: Volodymyr Babchuk <volodymyr_babc...@epam.com> >> CC: Bertrand Marquis <bertrand.marq...@arm.com> >> --- >> xen/arch/x86/mm/p2m.h | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/xen/arch/x86/mm/p2m.h b/xen/arch/x86/mm/p2m.h >> index cc0f6766e4df..dc706b8e4799 100644 >> --- a/xen/arch/x86/mm/p2m.h >> +++ b/xen/arch/x86/mm/p2m.h >> @@ -15,6 +15,9 @@ >> * along with this program; If not, see <http://www.gnu.org/licenses/>. >> */ >> >> +#ifndef __ARCH_MM_P2M_H__ >> +#define __ARCH_MM_P2M_H__ > Do we have any guidelines regarding guard naming? Some files seem to > use __ASM_X86_, others just __ASM and some just _X86.
Not really. This one is especially complicated because x86 has two of them. $ git ls-files | grep /p2m\.h arch/arm/include/asm/p2m.h arch/x86/include/asm/p2m.h arch/x86/mm/p2m.h ~Andrew
