Hi jan > -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: Thursday, May 5, 2022 10:23 PM > To: Penny Zheng <penny.zh...@arm.com> > Cc: Wei Chen <wei.c...@arm.com>; Henry Wang <henry.w...@arm.com>; > Andrew Cooper <andrew.coop...@citrix.com>; George Dunlap > <george.dun...@citrix.com>; Julien Grall <jul...@xen.org>; Stefano Stabellini > <sstabell...@kernel.org>; Wei Liu <w...@xen.org>; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap > > On 05.05.2022 15:44, Penny Zheng wrote: > > I misunderstand what you suggested here, I thought you were suggesting > > a way of stub function which could bring some optimization. > > The reason I introduced free_staticmem_pages and acquire_reserved_page > > here is that we now used them in common code, and if they are not > > defined(using stub) on !CONFIG_STATIC_MEMORY, we will have " hidden > symbol `xxx' isn't defined " compilation error. > > This is what I've asked for clarification about: If such errors surface, I'd > like to > understand why the respective call sites aren't DCE-ed by the compiler. >
Because both definition of PGC_reserved and is_domain_using_static_memory are not guarded by CONFIG_STATIC_MEMORY in the first place in arm-specific file. > Jan
