Re: [PATCH] xen/public: add new macro to ring.h

[Juergen Gross]

On 26.04.22 11:43, Jan Beulich wrote:

On 26.04.2022 11:08, Juergen Gross wrote:

--- a/xen/include/public/io/ring.h
+++ b/xen/include/public/io/ring.h
@@ -184,6 +184,11 @@ typedef struct __name##_back_ring __name##_back_ring_t

+    SHARED_RING_INIT(_s);                                               \
+    FRONT_RING_INIT(_r, _s, __size);                                    \
+} while (0)

#define FRONT_RING_INIT(_r, _s, __size) FRONT_RING_ATTACH(_r, _s, 0, __size) +#define XEN_FRONT_RING_INIT(_r, _s, __size) do { \

I think it would be good for the comment around line 100 to also
have a reference to this.

Okay.

As to style: Could I talk you into not further proliferating the
inappropriate use of underscore-prefixed names as macro parameters?
Even more so one with a double underscore?

Okay.

As to functionality: I take it that it is not viewed as an issue
that many of the macros here evaluate their arguments multiple
times?

I don't think this is problematic.


Juergen

OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature