On 08.04.2022 12:55, Roger Pau Monné wrote: > On Wed, Feb 23, 2022 at 04:59:42PM +0100, Jan Beulich wrote: >> ..., moving the former into the new physmap.c. Also call the new >> functions directly from arch_iommu_hwdom_init() and >> vpci_make_msix_hole(), as the PV/HVM split is explicit there. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> Reviewed-by: George Dunlap <george.dun...@ctirix.com> > > Reviewed-by: Roger Pau Monné <roger....@citrix.com>
Thanks. > Just one comment below, which can also be taken care in a followup > patch if you agree. > >> --- >> v2: Change arch_iommu_hwdom_init() and vpci_make_msix_hole(). >> >> --- a/xen/arch/x86/mm/p2m.c >> +++ b/xen/arch/x86/mm/p2m.c >> @@ -1473,12 +1473,9 @@ static int clear_mmio_p2m_entry(struct d >> return rc; >> } >> >> -#endif /* CONFIG_HVM */ >> - >> -int set_identity_p2m_entry(struct domain *d, unsigned long gfn_l, >> +int p2m_add_identity_entry(struct domain *d, unsigned long gfn_l, > > I guess switching the gfn_l parameter to be gfn_t gfn, and then > defining: > > unsigned long gfn_l = gfn_x(gfn); > > Was too much churn? Well, yes, I probably could have done that, but the series was (going to be) big enough already, so I tried to stay away from such (for consistency's sake I think I would then have needed to do the same elsewhere as well). Jan
