Hi Peng, On 07.04.2022 04:44, Peng Fan (OSS) wrote: > From: Peng Fan <peng....@nxp.com> > > Signed-off-by: Peng Fan <peng....@nxp.com> > --- > xen/arch/arm/Kconfig.debug | 14 +++++++ > xen/arch/arm/arm64/debug-imx-lpuart.inc | 52 +++++++++++++++++++++++++ > xen/arch/arm/include/asm/imx-lpuart.h | 22 +++++------ > 3 files changed, 77 insertions(+), 11 deletions(-) > create mode 100644 xen/arch/arm/arm64/debug-imx-lpuart.inc > > diff --git a/xen/arch/arm/include/asm/imx-lpuart.h > b/xen/arch/arm/include/asm/imx-lpuart.h > index 111640edb4..26e2cf0249 100644 > --- a/xen/arch/arm/include/asm/imx-lpuart.h > +++ b/xen/arch/arm/include/asm/imx-lpuart.h > @@ -30,10 +30,10 @@ > #define UARTFIFO (0x28) > #define UARTWATER (0x2c) > > -#define UARTSTAT_TDRE BIT(23) > -#define UARTSTAT_TC BIT(22) > -#define UARTSTAT_RDRF BIT(21) > -#define UARTSTAT_OR BIT(19) > +#define UARTSTAT_TDRE BIT(23, UL) > +#define UARTSTAT_TC BIT(22, UL) > +#define UARTSTAT_RDRF BIT(21, UL) > +#define UARTSTAT_OR BIT(19, UL) > > #define UARTBAUD_OSR_SHIFT (24) > #define UARTBAUD_OSR_MASK (0x1f) > @@ -42,13 +42,13 @@ > #define UARTBAUD_TDMAE (0x00800000) > #define UARTBAUD_RDMAE (0x00200000) > > -#define UARTCTRL_TIE BIT(23) > -#define UARTCTRL_TCIE BIT(22) > -#define UARTCTRL_RIE BIT(21) > -#define UARTCTRL_ILIE BIT(20) > -#define UARTCTRL_TE BIT(19) > -#define UARTCTRL_RE BIT(18) > -#define UARTCTRL_M BIT(4) > +#define UARTCTRL_TIE BIT(23, UL) > +#define UARTCTRL_TCIE BIT(22, UL) > +#define UARTCTRL_RIE BIT(21, UL) > +#define UARTCTRL_ILIE BIT(20, UL) > +#define UARTCTRL_TE BIT(19, UL) > +#define UARTCTRL_RE BIT(18, UL) > +#define UARTCTRL_M BIT(4, UL) > > #define UARTWATER_RXCNT_OFF 24 >
I find it a bit strange that you fix the header file in the patch 2/2 while patch 1/2 introduces it. Could you do these fixes in the patch where you create this file? Cheers, Michal
