On 24.03.2022 12:19, Juergen Gross wrote: > On 24.03.22 11:57, Jan Beulich wrote: >> On 24.03.2022 09:13, Juergen Gross wrote: >>> Today most hypercall handlers have a return type of long, while the >>> --- a/xen/arch/x86/x86_64/platform_hypercall.c >>> +++ b/xen/arch/x86/x86_64/platform_hypercall.c >>> @@ -4,6 +4,7 @@ >>> >>> EMIT_FILE; >>> >>> +#include <xen/hypercall.h> >>> #include <xen/lib.h> >>> #include <compat/platform.h> >>> #include <xen/hypercall.h> > > This seems to be an artifact of the rebase done in V4 of the series, which > was necessary as Andrew's large series used two patches of my V3 series. > > Do you want me to resend without this hunk?
Well, I'd also be fine if you tell me the proper resolution of the issue in the next patch. I guess the hunk there than also needs dropping? And patch 5 adjusting accordingly for context? Overall it may indeed be better if you resent ... Jan
