> On 15 Mar 2022, at 17:45, Andrew Cooper <andrew.coop...@citrix.com> wrote: > > On 10/03/2022 17:10, Luca Fancellu wrote: >> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h >> index 10ea969c7af9..47fc856e0fe0 100644 >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -1145,6 +1145,22 @@ int cpupool_move_domain(struct domain *d, struct >> cpupool *c); >> int cpupool_do_sysctl(struct xen_sysctl_cpupool_op *op); >> unsigned int cpupool_get_id(const struct domain *d); >> const cpumask_t *cpupool_valid_cpus(const struct cpupool *pool); >> + >> +/* >> + * cpupool_create_pool - Creates a cpupool >> + * @pool_id: id of the pool to be created >> + * @sched_id: id of the scheduler to be used for the pool >> + * >> + * Creates a cpupool with pool_id id. >> + * The sched_id parameter identifies the scheduler to be used, if it is >> + * negative, the default scheduler of Xen will be used. >> + * >> + * returns: >> + * pointer to the struct cpupool just created, on success >> + * NULL, on cpupool creation error > > What makes you say this? Your new function will fall over a NULL > pointer before it returns one...
You are right, it’s a leftover from the v1, I will change it and review the code that uses it. Cheers, Luca > > ~Andrew
