On Fri, Mar 11, 2022 at 03:21:07PM +0000, Jane Malalane wrote: > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index 117fcdcb2b..0ab9b145fe 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -1681,6 +1681,22 @@ void parse_config_data(const char *config_source, > xlu_cfg_get_defbool(config, "vpt_align", &b_info->u.hvm.vpt_align, > 0); > xlu_cfg_get_defbool(config, "apic", &b_info->apic, 0); > > + e = xlu_cfg_get_long(config, "assisted_xapic", &l , 0); > + if ((e == ESRCH && assisted_xapic != -1)) /* use global default if > present */ > + libxl_defbool_set(&b_info->arch_x86.assisted_xapic, > assisted_xapic); > + else if (!e) > + libxl_defbool_set(&b_info->arch_x86.assisted_xapic, l); > + else > + exit(1); > + > + e = xlu_cfg_get_long(config, "assisted_x2apic", &l, 0); > + if ((e == ESRCH && assisted_x2apic != -1)) /* use global default if > present */ > + libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, > assisted_x2apic); > + else if (!e) > + libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, l); > + else > + exit(1);
I think the placement here is not fully correct, as this is a LIBXL_DOMAIN_TYPE_HVM only code section. We need this also for LIBXL_DOMAIN_TYPE_PVH (or for !LIBXL_DOMAIN_TYPE_PV if that's easier). The rest LGTM. Thanks, Roger.
