On 08.03.2022 18:36, Jane Malalane wrote:
> @@ -685,13 +687,31 @@ int arch_sanitise_domain_config(struct
> xen_domctl_createdomain *config)
> }
> }
>
> - if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED )
> + if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED |
> + XEN_X86_ASSISTED_XAPIC |
> + XEN_X86_ASSISTED_X2APIC) )
> {
> dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n",
> config->arch.misc_flags);
> return -EINVAL;
> }
>
> + if ( (assisted_xapic || assisted_x2apic) && !hvm )
> + {
> + dprintk(XENLOG_INFO,
> + "Interrupt Controller Virtualization not supported for
> PV\n");
> + return -ENODEV;
> + }
> +
> + if ( (assisted_xapic && !assisted_xapic_available) ||
> + (assisted_x2apic && !assisted_x2apic_available) )
> + {
> + dprintk(XENLOG_INFO,
> + "Hardware assisted x%sAPIC requested but not available\n",
> + assisted_xapic && !assisted_xapic_available ? "" : "2");
> + return -EINVAL;
> + }
My understanding of the outcome of the prior discussion was the opposite
use of EINVAL and ENODEV respectively.
Jan
