On Thu, Mar 03, 2022 at 09:21:48AM +0100, Juergen Gross wrote: > On 25.02.22 16:13, Anthony PERARD wrote: > > diff --git a/tools/include/Makefile b/tools/include/Makefile > > index d965987f55..3a03a0b0fa 100644 > > --- a/tools/include/Makefile > > +++ b/tools/include/Makefile > > @@ -82,6 +82,7 @@ uninstall: > > clean: > > rm -rf xen xen-xsm acpi > > $(MAKE) -C xen-foreign clean > > + rm -f _*.h > > Use $(RM) instead? OTOH this could be done in a patch of its own > switching all rm -f instances to $(RM).
This isn't really something that I think matter. Per GNU make's manual, "rm" need to exist. Without it part of the build system could be broken. Also setting $(RM) to something other than "rm -f" isn't going to work well either. So whether we use $(RM) or `rm -f` shouldn't matter. All of that to say that I'm not necessarily change one for the other. It mostly depends on context. Also, I might change those "clean:" rules later to collect files to clean in a variable $(&CLEAN_FILES), when that will be possible. > Reviewed-by: Juergen Gross <jgr...@suse.com> Thanks, -- Anthony PERARD
