Hi Roger, > On 25 Feb 2022, at 8:20 am, Roger Pau Monné <roger....@citrix.com> wrote: > > On Tue, Feb 15, 2022 at 03:25:18PM +0000, Rahul Singh wrote: >> {read,write}{l,q} function argument is different for ARM and x86. >> ARM {read,wrie}(l,q} function argument is pointer whereas X86 >> {read,wrie}(l,q} function argument is address itself. >> >> {read,write}{l,q} is only used in common file to access the MSI-X PBA >> structure. To avoid impacting other x86 code and to make the code common >> move the read/write call to MSI-X PBA to arch specific file. > > I think we agreed where going to unify {read,write}{l,q} so they could > be used in arch-agnostic code?
We agreed to modify the vPCI MSIx code to use a pointer, but that not helped me to make code arch-agnostic. I decided to move the PBA handling code to an arch-specific file to make the code usable. Thanks for the series "vpci/msix: fix PBA acceses” series that will help to use the code for ARM arch also without any modification to {read,write}{l,q} . Regards, Rahul > > Thanks, Roger. >