On 14.02.2022 16:12, George Dunlap wrote: >> On Jul 5, 2021, at 5:12 PM, Jan Beulich <jbeul...@suse.com> wrote: >> >> Introduce an inline wrapper dealing with the non-translated-domain case, >> while stripping that logic from the main function, which gets renamed to >> p2m_get_gfn_type_access(). HVM-only callers can then directly use the >> main function. >> >> Along with renaming the main function also make its and the new inline >> helper's GFN parameters type-safe. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> > > Nit in the title: I read “HVM” as “aych vee emm”, and so I use ‘an’ before it > rather than ‘a’; i.e., “derive an HVM-only…” > > I feel obligated to mention it but I’ll leave it to you whether you want to > change it or not:
Thanks - I always appreciate clarification on my, frequently, improper language use. In the case here, however, I know people saying "aych" as well as ones saying "haych", so I'm always in trouble to judge which one's right (and probably both are). I therefore decided to simply drop the "a" from the title, which I think still leaves it be a proper one. > Reviewed-by: George Dunlap <george.dun...@citrix.com> And thanks again. Jan
