On 30.01.2022 04:17, Tian, Kevin wrote: >> From: Jan Beulich <jbeul...@suse.com> >> Sent: Tuesday, January 11, 2022 12:23 AM >> >> In order to be able to insert/remove super-pages we need to allow >> callers of the walking function to specify at which point to stop the >> walk. >> >> For intel_iommu_lookup_page() integrate the last level access into >> the main walking function. >> >> dma_pte_clear_one() gets only partly adjusted for now: Error handling >> and order parameter get put in place, but the order parameter remains >> ignored (just like intel_iommu_map_page()'s order part of the flags). >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> --- >> I was actually wondering whether it wouldn't make sense to integrate >> dma_pte_clear_one() into its only caller intel_iommu_unmap_page(), for >> better symmetry with intel_iommu_map_page(). > > I think it's the right thing to do. It was there due to multiple callers > when firstly introduced. But now given only one caller mering it > with the caller to be symmetry makes sense.
I guess I'll make this a separate change towards the end of this series now, to save me from some rebasing of other patches. > with or without that change (given it's simple): > > Reviewed-by: Kevin Tian <kevin.t...@intel.com> Thanks. Jan
