Hi Jan, > -----Original Message----- > From: Jan Beulich <jbeul...@suse.com> > Sent: 2022年1月27日 16:09 > To: Wei Chen <wei.c...@arm.com> > Cc: Bertrand Marquis <bertrand.marq...@arm.com>; xen- > de...@lists.xenproject.org; sstabell...@kernel.org; jul...@xen.org > Subject: Re: [PATCH 12/37] xen/x86: decouple nodes_cover_memory from E820 > map > > On 27.01.2022 09:03, Wei Chen wrote: > >> From: Jan Beulich <jbeul...@suse.com> > >> Sent: 2022年1月25日 0:59 > >> > >> On 23.09.2021 14:02, Wei Chen wrote: > >>> We will reuse nodes_cover_memory for Arm to check its bootmem > >>> info. So we introduce two arch helpers to get memory map's > >>> entry number and specified entry's range: > >>> arch_get_memory_bank_number > >>> arch_get_memory_bank_range > >> > >> I'm sorry, but personally I see no way for you to introduce the term > >> "memory bank" into x86 code. > > > > In my latest changes, I have updated these two helpers to: > > uint32_t __init arch_meminfo_get_nr_bank(void) > > __init arch_meminfo_get_ram_bank_range(...) > > I am sorry, I forgot to change the commit log accordingly. > > I will update it in next version. > > I'm sorry for the ambiguity of my earlier reply, but my objection was > against "bank", not "memory". As an aside, you also don't want the
How about arch_meminfo_get_nr_map/ arch_meminfo_get_map_range? I am sorry, I am not very familiar with e820 map, could you give me some suggestions? > function return "uint32_t" - see ./CODING_STYLE. OK. > > Jan
