On 23.09.2021 14:02, Wei Chen wrote: > srat_bad is used when NUMA initialization code scan SRAT failed. > It will turn fw_numa to disabled status. Its implementation depends > on NUMA implementation. We want every NUMA implementation to provide > this function for common initialization code. > > In this patch, we export srat_bad to external. This will allow to > have the code mostly common.
Here as well as in the subject it would help if the function name wasn't the wrong way round. I also don't see how you mean to use a function containing "srat" in its name from non-ACPI code. Perhaps alongside numa_mode() (see the reply to the earlier patch) you want to have a set_numa_off() helper (name subject to improvement)? > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -163,7 +163,7 @@ static __init void cutoff_node(int i, paddr_t start, > paddr_t end) > } > } > > -static __init void bad_srat(void) > +__init void bad_srat(void) Nit: Once again, when touching code, please take the opportunity and adjust style issues (here: __init and void want to change places). Jan
