On Thu, Dec 16, 2021 at 05:55:29PM +0000, Andrew Cooper wrote: > On 06/12/2021 17:02, Anthony PERARD wrote: > > diff --git a/tools/debugger/gdbsx/Makefile b/tools/debugger/gdbsx/Makefile > > index 8d7cd94a31..4aaf427c45 100644 > > --- a/tools/debugger/gdbsx/Makefile > > +++ b/tools/debugger/gdbsx/Makefile > > @@ -28,7 +28,7 @@ uninstall: > > gdbsx: gx/gx_all.a xg/xg_all.a > > $(CC) $(LDFLAGS) -o $@ $^ > > > > -xg/xg_all.a: > > +xg/xg_all.a: FORCE > > $(MAKE) -C xg > > -gx/gx_all.a: > > +gx/gx_all.a: FORCE > > $(MAKE) -C gx > > Shouldn't these be in the sub Make's ?
No, this is how we tell make how to build some of the prerequisite needed to build "gdbsx", we tell make that they are build in sub-directory. > > diff --git a/tools/debugger/gdbsx/gx/Makefile > > b/tools/debugger/gdbsx/gx/Makefile > > -#%.o: %.c $(GX_HDRS) Makefile > > -# $(CC) -c $(CFLAGS) -o $@ $< > > - > > -gx_all.a: $(GX_OBJS) Makefile $(GX_HDRS) > > - ar cr $@ $(GX_OBJS) # problem with ld using -m32 > > +gx_all.a: $(GX_OBJS) Makefile > > + ar cr $@ $(GX_OBJS) > > There's probably an $(AR) we ought to be using. Yes, I'll look at that. Thanks, -- Anthony PERARD
