Hi Juergen,

On 08/12/2021 15:55, Juergen Gross wrote:
Today Arm is using another entry point for the vcpu_op hypercall as

NIT: The 'as' doesn't sound right here. Did you mean 'compare to'?

x86, as some of the common sub-ops are not supported on Arm. The Arm
specific handler filetrs out the not supported sub-ops and then calls

Typo: s/filetrs/filters/

the common handler. This leads to the weird call hierarchy:

   do_arm_vcpu_op()
     do_vcpu_op()
       arch_do_vcpu_op()

Clean this up by renaming do_vcpu_op() to common_vcpu_op() and
arch_do_vcpu_op() in each architecture to do_vcpu_op(). This way one
of above calls can be avoided without restricting any potential
future use of common sub-ops for Arm.

Additionally the single user of HYPERCALL_ARM() can be modified and
HYPERCALL_ARM() can be removed.

Signed-off-by: Juergen Gross <jgr...@suse.com>

Reviewed-by: Julien Grall <jgr...@amazon.com>

Cheers,

--
Julien Grall

Reply via email to