On Mon, Dec 13, 2021 at 05:56:33PM +0000, Andrew Cooper wrote:
> Fixes: a5706b80f42e ("Set version to 4.17: rerun autogen.sh")
> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
> ---
> CC: Wei Liu <w...@xen.org>
> CC: Anthony PERARD <anthony.per...@citrix.com>
> CC: Juergen Gross <jgr...@suse.com>
>
> This gets forgotten each release. Any chance we can move libfsimage and/or
> libacpi into libs/, where this issue would go away.
libfsimage is a weird kind of library, I don't think it's going to sit
well in libs/, and I don't think moving it just because MAJOR hasn't been
bumped is a good reason...
libacpi isn't a library, not really. It's a collection of source files
designed to be embedded into other programmes.
You know, we could simply replace "4.16" by
$(shell $(XEN_ROOT)/version.sh $(XEN_ROOT)/xen/Makefile)
then we can forget libfsimage exist.
Any any case,
Acked-by: Anthony PERARD <anthony.per...@citrix.com>
for this patch, or for using version.sh instead.
> ---
> tools/libfsimage/common/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/libfsimage/common/Makefile
> b/tools/libfsimage/common/Makefile
> index 24bc90e73e71..54049ebaae86 100644
> --- a/tools/libfsimage/common/Makefile
> +++ b/tools/libfsimage/common/Makefile
> @@ -1,7 +1,7 @@
> XEN_ROOT = $(CURDIR)/../../..
> include $(XEN_ROOT)/tools/libfsimage/Rules.mk
>
> -MAJOR = 4.16
> +MAJOR = 4.17
> MINOR = 0
>
> LDFLAGS-$(CONFIG_SunOS) = -Wl,-M -Wl,mapfile-SunOS
Thanks,
--
Anthony PERARD
