On 02/12/2021 11:56, Jan Beulich wrote: > On 30.11.2021 11:04, Andrew Cooper wrote: >> The calculation in __start_xen() for xen_virt_end is an opencoding of >> ROUNDUP(_end, 2M). This is __2M_rwdata_end as provided by the linker script. >> >> This corrects the bound calculations in arch_livepatch_init() and >> update_xen_mappings() to not enforce 2M alignment when Xen is not compiled >> with CONFIG_XEN_ALIGN_2M >> >> Furthermore, since 52975142d154 ("x86/boot: Create the l2_xenmap[] mappings >> dynamically"), there have not been extraneous mappings to delete, meaning >> that >> the call to destroy_xen_mappings() has been a no-op. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > While there's a contextual conflict with patch 4, my understanding is > that this one is independent of that.
Correct. I was in the middle of writing this patch when I discovered the disaster which is the logic in patch 4. > On that basis > Reviewed-by: Jan Beulich <jbeul...@suse.com> Thanks. ~Andrew