On 30.11.2021 11:04, Andrew Cooper wrote: > multiboot_ptr should be in __initdata - it is only used on the BSP path. > Furthermore, the .align 8 then .long means that stack_start is misaligned. > > Move both into setup.c, which lets the compiler handle the details correctly, > as well as providling proper debug information for them. > > Declare stack_start in setup.h and avoid extern-ing it locally in smpboot.c. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com> Nevertheless I'd like to state that defining a variable in C when all its uses are in assembly seems a little odd to me. Jan
