On 17.11.2021 17:48, Andrew Cooper wrote: > There are several cases where the act of interrupting a remote processor has > the required side effect. Explicitly allow NULL function pointers so the > calling code doesn't have to provide a stub implementation. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Roger Pau Monné <roger....@citrix.com> > CC: Wei Liu <w...@xen.org> > > The wait parameter is a little weird. It serves double duty and will confirm > that the IPI has been taken. All it does is let you control whether you also > wait for the handler to complete first. As such, it is effectively useless > with a stub function. > > I don't particularly like folding into the .wait() path like that, but I > dislike it less than an if()/else if() and adding a 3rd cpumask_clear_cpu() > into the confusion which is this logic.
I can accept this, albeit personally I would have preferred the extra if() over the goto. Reviewed-by: Jan Beulich <jbeul...@suse.com> Jan
