On Wed, Nov 03, 2021 at 11:20:59AM +0100, Juergen Gross wrote: > diff --git a/xen/Makefile b/xen/Makefile > index a3189eb47c..dfdae47e74 100644 > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -405,6 +406,7 @@ $(TARGET): delete-unfresh-files > $(MAKE) -f $(BASEDIR)/Rules.mk -C include > $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) include > $(MAKE) -f $(BASEDIR)/Rules.mk include/asm-$(TARGET_ARCH)/asm-offsets.h > + $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/hypercall-defs.h > $(MAKE) -f $(BASEDIR)/Rules.mk -C arch/$(TARGET_ARCH) $@ > > # drivers/char/console.o contains static banner/compile info. Blow it away. > @@ -466,6 +468,14 @@ include/asm-$(TARGET_ARCH)/asm-offsets.h: asm-offsets.s > echo ""; \ > echo "#endif") <$< >$@ > > +quiet_cmd_genhyp = GEN $@ > +define cmd_genhyp > + awk -f scripts/gen_hypercall.awk <$< >$@ > +endef > + > +include/xen/hypercall-defs.h: include/hypercall-defs.i > scripts/gen_hypercall.awk FORCE > + $(call if_changed,genhyp) > +
Is there a reason to generate "hypercall-defs.h" here? Could this be moved to include/Makefile instead? Then, when moved to include/Makefile, I think you would need to add both "xen/hypercall-def.h" and "hypercall-defs.i" to $(targets) to avoid them been rebuilt needlessly. Thanks, -- Anthony PERARD
