On 29/09/2021 09:07, Jan Beulich wrote:
> On 28.09.2021 23:00, Andrew Cooper wrote:
>> The call to debugger_trap_entry() should pass the correct vector. The
>> break-for-gdbsx logic is in practice unreachable because PV guests can't
>> generate #CP, but it will interfere with anyone inserting custom debugging
>> into debugger_trap_entry().
>>
>> Fixes: 5ad05b9c2490 ("x86/traps: Implement #CP handler and extend #PF for
>> shadow stacks")
>> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
> Reviewed-by: Jan Beulich <jbeul...@suse.com>
>
It turns out that I forgot to commit this patch, and it now needs a
Release Ack to go in.
It is very safe and obvious. It is passing the wrong constant into a
debug function.
Luckily the impact is benign due to other properties of the logic, and
would only cause problems for people adding manual debug logic.
~Andrew
