>>> On 19.03.18 at 20:13, <andrew.coop...@citrix.com> wrote: > This is in preparation to set up d->max_cpus and d->vcpu[] in > arch_domain_create(), and allow later parts of domain construction to have > access to the values.
I'm not convinced of the allocation to be done in arch_domain_create() (in the next patch), and hence I'm not sure we need what you do here. I can see that you want arch code to audit the vCPU count, but why does arch code need to set up the array and store ->max_vcpus? You could simply call a per-arch auditing function early (even the lower bound check could be done in common code), set up both fields early in domain_create(), and leave the call to arch_domain_create() where it is now, couldn't you? As the ARM auditing may need to do more than just auditing (to select the vGIC variant), perhaps this could be arch_domain_configure(), doing the auditing and all necessary setup needed for the auditing to be possible. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
