On 06/10/2021 18:40, Rahul Singh wrote: > Introduce XEN_DOMCTL_CDF_vpci flag to enable VPCI support in XEN. > Reject the use of this new flag for x86 as VPCI is not supported for > DOMU guests for x86. > > Signed-off-by: Rahul Singh <rahul.si...@arm.com> > Reviewed-by: Stefano Stabellini <sstabell...@kernel.org> > Acked-by: Christian Lindig <christian.lin...@citrix.com>
I'm afraid this logic is broken. There's no matching feature to indicate to the toolstack whether XEN_DOMCTL_CDF_vpci will be accepted or not. The usual way of doing this is with a physinfo_cap field. This flag needs using in Patch 10 to reject attempts to create a VM with devices when passthrough support is unavailable. Ian, for the 4.16 release, this series either needs completing with the additional flag implemented, or this patch needs reverting to avoid us shipping a broken interface. ~Andrew
