Am 23.03.2018 um 11:22 hat Daniel P. Berrangé geschrieben: > On Thu, Mar 22, 2018 at 09:27:55PM +0200, Michael S. Tsirkin wrote: > > Make sure all generated files go into qemu-build subdirectory. > > We can then include them like this: > > #include "qemu-build/trace.h" > > > > This serves two purposes: > > - make it easy to detect which files are in the source > > directory (a bit more work for writers, easier for readers) > > - reduce chances of conflicts with possible stale files in source > > directory (which could be left over from e.g. old patches, etc) > > If people care about this, then they can just be doing a build > with srcdir != builddir config. If people are using srcdir == builddir > then they likely *want* all the generated files in their srcdir. > > IMHO it would be valid for us to consider if we could just mandate > srcdir != builddir, but if people object to such a proposal, then I > don't think we should arbitrarily move all generated source files > in this way, as that's effectively the same thing forced onto devs.
Not necessarily. I build from the srcdir simply because it's more convenient to be able to easily start the editor and make from the same directory (or sometimes start make from inside the editor). I suppose that (or for users, being too lazy to create a second directory for that one-time build) is the motivation for most other users of srcdir == builddir, too. I don't really mind where generated source files are stored, they just happen to end up in my root source directory if I want to be able to build from there without dealing with paths. I won't be angry if they are suddenly in a different directory as long as it doesn't mean more typing for me. Moving them to a separate directory might in fact make things a bit nicer occasionally. Not enough for me to actively propose such a change, but if Michael wants to do this, I'm certainly not opposed. Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
