On 29.09.2021 11:03, Oleksandr Andrushchenko wrote: > Sorry for top posting, but this is a general question on this > patch/functionality. > > Do you see we need to gate all this with CONFIG_HAS_VPCI_GUEST_SUPPORT > as this renders in somewhat dead code for x86 for now? I do think this still > needs to be in the common code though.
I agree it wants to live in common code, but I'd still like the code to not bloat x86 binaries. Hence yes, I think there want to be "if ( !IS_ENABLED() )" early bailout paths or, whenever this isn't possible without breaking the build, respective #ifdef-s. Jan
