On 23.09.2021 11:54, Julien Grall wrote: > On 23/09/2021 08:11, Penny Zheng wrote: >> From: Stefano Stabellini <stefano.stabell...@xilinx.com> >> >> We are passing an extra special boolean flag at domain creation to >> specify whether we want to the domain to be privileged (i.e. dom0) or >> not. Another flag will be introduced later in this series. >> >> Reserve bits 16-31 from the existing flags bitfield in struct >> xen_domctl_createdomain for internal Xen usage. > > I am a bit split with this approach. This feels a bit of a hack to > reserve bits for internal purpose in external headers. But at the same > time I can see how this is easier to deal with it over repurposing the > last argument of domain_create().
I actually have trouble seeing why that's easier. It is a common thing to widen a bool to "unsigned int flags" when more than one control is needed. Plus this makes things needlessly harder once (in the future) the low 16 bits are exhausted in the public interface. Jan
