On 23.09.2021 14:02, Wei Chen wrote: > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -34,6 +34,17 @@ config ACPI > Advanced Configuration and Power Interface (ACPI) support for Xen is > an alternative to device tree on ARM64. > > + config DEVICE_TREE_NUMA > + def_bool n > + select NUMA
Two nits here: There's a stray blank on the first line, and you appear to mean just "bool", not "def_bool n" (there's no point in having defaults for select-only options). > +config ARM_NUMA > + bool "Arm NUMA (Non-Uniform Memory Access) Support (UNSUPPORTED)" if > UNSUPPORTED > + select DEVICE_TREE_NUMA if HAS_DEVICE_TREE > + ---help--- And another nit here: We try to move away from "---help---", which is no longer supported by Linux'es newer kconfig. Please use just "help" in new code. Jan
