Hi Julien, > On 23 Sep 2021, at 9:52 am, Julien Grall <jul...@xen.org> wrote: > > Hi, > > On 23/09/2021 07:23, Stefano Stabellini wrote: >>> diff --git a/xen/include/asm-arm/pci.h b/xen/include/asm-arm/pci.h >>> index 4b32c7088a..5406daecda 100644 >>> --- a/xen/include/asm-arm/pci.h >>> +++ b/xen/include/asm-arm/pci.h >>> @@ -18,6 +18,7 @@ >>> #ifdef CONFIG_HAS_PCI >>> #define pci_to_dev(pcidev) (&(pcidev)->arch.dev) >>> +#define PRI_pci "%04x:%02x:%02x.%u" >> This is added in this patch but it is unused here > > To add on this, this is technically not arch specific. So if this is > necessary in a follow-up patch, then the definition should be moved to a > generic header.
I introduces this to print SDBF but I think it is better to use %pp to print SBDF. I will remove this in next version. Regards, Rahul > Cheers, > > -- > Julien Grall