On 22.09.2021 13:48, Bertrand Marquis wrote:
>> On 22 Sep 2021, at 12:44, Penny Zheng <penny.zh...@arm.com> wrote:
>>
>> Commit 540a637c3410780b519fc055f432afe271f642f8 defines a new
>> helper mark_page_free to extract common codes, while it accidently
>> breaks the local variable "tainted".
>>
>> This patch fix it by letting mark_page_free() return bool of whether the
>> page is offlined and rename local variable "tainted" to "pg_offlined".
>>
>> Coverity ID: 1491872
>>
>> Fixes: 540a637c3410780b519fc055f432afe271f642f8
>> Signed-off-by: Penny Zheng <penny.zh...@arm.com>
> Reviewed-by: Bertrand Marquis <bertrand.marq...@arm.com>
Acked-by: Jan Beulich <jbeul...@suse.com>
Albeit I would have wished that ...
>> @@ -1433,7 +1437,7 @@ static void free_heap_pages(
>> {
>> unsigned long mask;
>> mfn_t mfn = page_to_mfn(pg);
>> - unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), tainted = 0;
>> + unsigned int i, node = phys_to_nid(mfn_to_maddr(mfn)), pg_offlined = 0;
... this would have become properly bool as well.
Jan
