On 20.09.21 12:34, Ian Jackson wrote:
Roger Pau Monne writes ("[PATCH 4/6] tools/xenstored: use atexit to close interfaces"):Exploiting the talloc clean up routines to close the Xen interfaces is cumbersome, specially when atexit can be used to the same effect.Wait, what ? Why do we need to do this at all ? xenstored can't be restarted so if it exits we might as well leave whatever wreckage.
In practice, yes. But having those cleanups might make it easier to find memory leaks. Why do we have cleanups in normal Xen tools before exiting? The system is doing cleanup anyway... ;-)
AIUI the live update doesn't end up calling atexit ?
That's correct. Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature
Description: OpenPGP digital signature
