On 9/3/21 10:18 PM, Richard Henderson wrote: > On 9/2/21 6:15 PM, Philippe Mathieu-Daudé wrote: >> Restrict has_work() to TCG sysemu. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >> --- >> target/alpha/cpu.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c >> index 93e16a2ffb4..32cf5a2ea9f 100644 >> --- a/target/alpha/cpu.c >> +++ b/target/alpha/cpu.c >> @@ -33,6 +33,7 @@ static void alpha_cpu_set_pc(CPUState *cs, vaddr value) >> cpu->env.pc = value; >> } >> +#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) >> static bool alpha_cpu_has_work(CPUState *cs) > > Drop CONFIG_TCG for alpha; it's always true.
What is the rational? "Old" architectures (with no active / official hw development) are unlikely to add hardware acceleration, so TCG is the single one possible? Thus no need to clutter the code with obvious #ifdef'ry? > Otherwise, > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > r~ >
