On 26.08.2021 16:27, Andrew Cooper wrote: > On 26/08/2021 08:26, Jan Beulich wrote: >> TBD: I find the ordering in amd_iommu_disable_domain_device() >> suspicious: amd_iommu_enable_domain_device() sets up the DTE first >> and then enables ATS on the device. It would seem to me that >> disabling would better be done the other way around (disable ATS on >> device, then adjust DTE). > > I'd hope that the worst which goes wrong, given the problematic order, > is a master abort. > > But yes - ATS wants disabling on the device first, before the DTE is > updated.
Okay, I'll add another patch. Jan
