On Thu, Aug 05, 2021 at 09:04:18AM +0200, Jan Beulich wrote: > On 01.07.2021 16:09, Anthony PERARD wrote: > > This avoid the need to create the symbolic link "include/asm". > > > > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > > --- > > > > Other possible locations that I could think of: > > include/arch/*/asm > > arch/*/include/asm > > I thought it was always the plan to follow Linux (and kind of XTF) in > this regard, using the latter of these options?
I'm not sure what the plan was, but putting the arch specific headers in arch/ sound good. I'll rework the patch. > > --- a/xen/include/xen/bitmap.h > > +++ b/xen/include/xen/bitmap.h > > @@ -14,7 +14,7 @@ > > * > > * Function implementations generic to all architectures are in > > * lib/bitmap.c. Functions implementations that are architecture > > - * specific are in various include/asm-<arch>/bitops.h headers > > + * specific are in various include/arch-<arch>/asm/bitops.h headers > > Then, just to take this as an example, referring to just asm/bitops.h > in comments might be enough (limiting churn on some of the ones that > you're altering)? Sound good. Thanks, -- Anthony PERARD
