On 7/24/21 4:07 PM, Daniel P. Smith wrote: > On 7/16/21 3:34 AM, Jan Beulich wrote: >> On 12.07.2021 22:32, Daniel P. Smith wrote: >>> With the elimination of switching how dummy.h gets included, the function >>> declaration macros are no longer necessary. This commit expands them out to >>> the >>> only value for which they will ever be set. This results in function >>> declaration lengths changing and since some definitions did not even follow >>> the >>> 80 column wrapping style, all function definitions were aligned with the >>> predominate style found in core hypervisor code. >> >> I'm afraid this last half sentence is quite far from true: > > I would disagree since I know I went through the frustration of trying > to find a discernible consistency in the files in common/ in the end I > settled on following common/memory.c since it seemed to have the most > uniform, it had only a couple of anomalies, as opposed to other files > where indentation was varied throughout. >
Going back into the patch I found what happened. I am not sure how, but every parameter line I wrapped had 7 additional spaces. This has been corrected. v/r dps
