On 23.07.2021 01:36, Stefano Stabellini wrote: > --- a/xen/drivers/passthrough/device_tree.c > +++ b/xen/drivers/passthrough/device_tree.c > @@ -140,8 +140,13 @@ int iommu_add_dt_device(struct dt_device_node *np) > if ( !ops ) > return -EINVAL; > > + /* > + * Some Device Trees may expose both legacy SMMU and generic > + * IOMMU bindings together. If both are present, the device > + * can be already added. > + */ > if ( dev_iommu_fwspec_get(dev) ) > - return -EEXIST; > + return 0;
Since the xen: prefix in the subject made me go look (I wouldn't have if it had been e.g. dt: ), I may as well ask: Since previously there was concern about bogus duplicate entries, does this concern go away no altogether? It's one thing for there to be a legacy and a generic binding, but another if you found two legacy or two generic ones, I would think. And what if legacy and generic representation differ in some way? Shouldn't you limit processing to just one of the two categories, such that no legitimate "already present" case could be encountered here in the first place? Jan
