Re: [RFC PATCH 2/4] xen/arm: Import ID features sanitize from linux

[Julien Grall]

Hi Bertrand,

On 12/07/2021 11:50, Bertrand Marquis wrote:
+#define __ARM64_FTR_BITS(SIGNED, VISIBLE, STRICT, TYPE, SHIFT, WIDTH, 
SAFE_VAL) \
+       {                                               \
+               .sign = SIGNED,                         \
+               .visible = VISIBLE,                     \
+               .strict = STRICT,                       \
+               .type = TYPE,                           \
+               .shift = SHIFT,                         \
+               .width = WIDTH,                         \
+               .safe_val = SAFE_VAL,                   \
+       }
+
+/* Define a feature with unsigned values */
+#define ARM64_FTR_BITS(VISIBLE, STRICT, TYPE, SHIFT, WIDTH, SAFE_VAL) \
+       __ARM64_FTR_BITS(FTR_UNSIGNED, VISIBLE, STRICT, TYPE, SHIFT, WIDTH, 
SAFE_VAL)
+
+/* Define a feature with a signed value */
+#define S_ARM64_FTR_BITS(VISIBLE, STRICT, TYPE, SHIFT, WIDTH, SAFE_VAL) \
+       __ARM64_FTR_BITS(FTR_SIGNED, VISIBLE, STRICT, TYPE, SHIFT, WIDTH, 
SAFE_VAL)
+
+#define ARM64_FTR_END                                  \
+       {                                               \
+               .width = 0,                             \
+       }
+
+static void cpu_enable_cnp(struct arm64_cpu_capabilities const *cap);

This function is not defined in the code you import.

I imported the block I am interested in from Linux and I am filtering it in the
Next patch where I remove those function prototypes.
I find it a bit confusing because most of the code imported makes sense 
except the two prototypes. At the same time...


This was to allow easier update of the code.

... I agree with this because if we need a resync of this patch, we may 
inadvertently re-introduce the prototype. So...


Should I filter directly when importing linux code then ?

... I will leave that up to you.

Cheers,

--
Julien Grall