On Tue, Mar 20, 2018 at 03:50:02PM +0200, Michael S. Tsirkin wrote: > On Tue, Mar 20, 2018 at 01:41:17PM +0000, Daniel P. Berrangé wrote: > > On Tue, Mar 20, 2018 at 02:32:16PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > > > So for these, we should use "". None of these are generated files > > > > > though. > > > > > > > > That leads to crazy inconsistent message for developers where 50% of > > > > QEMU > > > > header files must use <> and the other 50% of header files must use "". > > > > > > The rules are pretty simple though: > > > > > > (1) Headers which are generated use <>. > > > (2) Headers which are in include/ use <>. > > > (3) Headers sitting in the same directory as the source files use "". > > > > We have 1200 header files in QEMU - a developer might just reasonably > > remember > > which header file is a QEMU header, vs which is a 3rd party system header. > > Expecting devs to remember which of those 3 buckets each QEMU header falls > > under is unreasonable IMHO. > > That's the C language for you though. For better or worse, these are > the rules that K&R came up with.
No one seriously tries to keep compliance with original K&R C these days, things have moved on massively since then. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
