Hi Julien

> -----Original Message-----
> From: Julien Grall <jul...@xen.org>
> Sent: Thursday, July 1, 2021 1:45 AM
> To: Penny Zheng <penny.zh...@arm.com>; xen-devel@lists.xenproject.org;
> sstabell...@kernel.org; jbeul...@suse.com
> Cc: Bertrand Marquis <bertrand.marq...@arm.com>; Wei Chen
> <wei.c...@arm.com>
> Subject: Re: [PATCH 3/9] xen/arm: introduce CONFIG_STATIC_ALLOCATION
> 
> Hi Penny,
> 
> On 07/06/2021 03:43, Penny Zheng wrote:
> > For now, since the feature of Domain on Static Allocation is only
> > supported on ARM Architecture, this commit introduces new
> > CONFIG_STATIC_ALLOCATION to avoid bringing dead codes in other archs.
> 
> Similarly to patch #2, I think it would be better to introduce this Kconfig 
> when
> it is used or after the common code is introduced. This would prevent dead
> Kconfig.
> 

sure, I'll remove this commit, and combine it with the codes where this config 
is firstly used.

Cheers

> Cheers,
> 
> > Signed-off-by: Penny Zheng <penny.zh...@arm.com>
> > ---
> > changes v2:
> > - new commit
> > ---
> >   xen/arch/arm/Kconfig | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index
> > ecfa6822e4..f165db8ecd 100644
> > --- a/xen/arch/arm/Kconfig
> > +++ b/xen/arch/arm/Kconfig
> > @@ -278,6 +278,9 @@ config ARM64_ERRATUM_1286807
> >
> >       If unsure, say Y.
> >
> > +config STATIC_ALLOCATION
> > +    def_bool y
> > +
> >   endmenu
> >
> >   config ARM64_HARDEN_BRANCH_PREDICTOR
> >
> 
> --
> Julien Grall

--
Penny Zheng

Reply via email to